-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: Modify buf.yaml for Buf lint and Format with Buf CLI Comamnd("buf format -w") #354
multi: Modify buf.yaml for Buf lint and Format with Buf CLI Comamnd("buf format -w") #354
Conversation
Thank you for continuing to provide changes aimed at improving the development experience. |
@YusukeShimizu |
ef0b165
to
268c6b9
Compare
@YusukeShimizu
Please check when you have time. |
I think introducing buf-action is appropriate, and there’s no issue with the CI content. [Q]It’s not entirely clear how developers are expected to run Buf commands (e.g., buf format -w) locally. We can generate code with “make all-rpc-docker,” but what should we do for other commands? |
It seems that all-rpc is also a command that requires prior environment setup. |
268c6b9
to
c41c475
Compare
Thank you for raising this question. I recommend to install Buf Locally, developers can install Buf on their local machine following the official Buf installation guide and run the required commands directly.
I updated README and add usage_buf.md, please check. I have added other commands, such as lint and format, to the Makefile, just like all-rpc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We might consider installing buf via nix flake, but it’s already quite user-friendly as it is. Thanks!
Since this change is intended to enhance the developer experience without affecting behavior, I’ll merge it.
Issue number: none but related #343
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information